[wp-trac] [WordPress Trac] #46608: Being in recovery mode is easy to not realise you are in it

[WordPress Trac]

#46608: Being in recovery mode is easy to not realise you are in it
----------------------------------+----------------------------
 Reporter:  karmatosed            |       Owner:  (none)
     Type:  task (blessed)        |      Status:  new
 Priority:  high                  |   Milestone:  5.2
Component:  Administration        |     Version:  trunk
 Severity:  normal                |  Resolution:
 Keywords:  servehappy has-patch  |     Focuses:  accessibility
----------------------------------+----------------------------

Comment (by flixos90):

 During WCLDN we created [attachment:"46608.2.diff"] which iterates on the
 previous patch. It includes the following changes:

 * Provide the Exit Recovery Link background color in a way that it covers
 all possible scenarios (with WordPress's often way too specific CSS
 selectors :) ).
 * Provide an alternate background color for hover/focus. This color hasn't
 been used in WordPress before and is based on the "Fire Orange (Shade
 10%)" from https://codepen.io/hugobaeta/pen/RNOzoV (the regular color is
 "Fire Orange", so to get from that color to the new one, in Sass you need
 to use `mix( black, srcColor, 10%)`.
 * Add Exit Recovery Link style support to the different color schemes
 (using the above Sass function), in a way that is backward-compatible with
 all color schemes (also custom ones) without them being required to define
 a new variable.
 * Exit recovery mode when logging out.
 * Display an admin notice informing about recovery mode and exit
 opportunities with the following content: "You are in recovery mode. This
 means there may be an error with a theme or plugin. To exit recovery mode,
 log out or use the Exit button."
 * Ensure login title is also adjusted when already in recovery mode from
 before.

 After discussion, we decided to not exit recovery mode when resuming a
 plugin or theme for the first iteration. Making this a more intelligent
 process is however something to improve post-5.2.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46608#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform