[wp-trac] [WordPress Trac] #44836: Uploaded plugin installation page: There is an extra <p> tag messing with a link

[WordPress Trac]

#44836: Uploaded plugin installation page: There is an extra <p> tag messing with a
link
---------------------------------------------+-----------------------------
 Reporter:  seedsca                          |       Owner:  SergeyBiryukov
     Type:  defect (bug)                     |      Status:  reviewing
 Priority:  normal                           |   Milestone:  5.2
Component:  Upload                           |     Version:  4.9.8
 Severity:  minor                            |  Resolution:
 Keywords:  good-first-bug has-patch commit  |     Focuses:  ui,
                                             |  administration
---------------------------------------------+-----------------------------

Comment (by mukesh27):

 I tested patch
 [https://core.trac.wordpress.org/attachment/ticket/44836/44836.3.diff
 44836.3.diff] and it working fine in trunk version.

 In current situation if we remove {{{ vertical-align: top; }}} from below
 buttons.css then it will resolve the alignment issue and that active
 button state use {{{ .wp-core-ui p .button { vertical-align: baseline; }
 }}} child css.

 {{{
 .wp-core-ui .button-primary.active, .wp-core-ui .button-
 primary.active:hover, .wp-core-ui .button-primary.active:focus, .wp-core-
 ui .button-primary:active {
     background: #0073aa;
     border-color: #006799;
     box-shadow: inset 0 2px 0 #006799;
     /*vertical-align: top;*/
 }
 }}}

 Class button-primary is used in whole core buttons so can we replace {{{
 vertical-align: top; }}} to {{{ vertical-align: baseline; }}} in above
 css?

 @ianbelanger can you please check this.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44836#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform