[wp-trac] [WordPress Trac] #46778: Twenty Thirteen: Add styles to support the section block
WordPress Trac
noreply at wordpress.org
Wed Apr 3 14:47:50 UTC 2019
#46778: Twenty Thirteen: Add styles to support the section block
-------------------------------------+---------------------
Reporter: kjellr | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 5.3
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: needs-testing has-patch | Focuses:
-------------------------------------+---------------------
Comment (by kjellr):
Update: I've added got a new patch (`46778.patch`) that includes both the
front end and editor styles. Here's a screenshot of the editor, before and
after:
[[Image(https://cldup.com/P6NJ8k5XdX-1200x1200.png)]]
A few quick notes:
- The editor styles are much slimmer than the front end styles, because
Gutenberg ships with editor styles for this block. It does not provide
front end styles.
- The editor style selectors are a little unwieldy, but that's because
they need to select direct children of the section block. Unfortunately,
there's a lot of extra cruft in between blocks, and these styles are
overriding fairly specific built-in selectors:
https://github.com/WordPress/gutenberg/blob/ad7d183b493177992b720b66506f1cc71dd95b0a/packages
/block-library/src/section/editor.scss#L21
I'd appreciate some testing + review whenever someone has a moment!
Thanks.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46778#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list