[wp-trac] [WordPress Trac] #45755: Theme Editor WSOD functionality doesn't work with Multisite

[WordPress Trac]

#45755: Theme Editor WSOD functionality doesn't work with Multisite
-------------------------------------+-----------------------------
 Reporter:  dd32                     |       Owner:  desrosj
     Type:  defect (bug)             |      Status:  reviewing
 Priority:  normal                   |   Milestone:  Future Release
Component:  Networks and Sites       |     Version:  4.9
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:  multisite
-------------------------------------+-----------------------------
Changes (by desrosj):

 * keywords:  has-patch commit => has-patch needs-refresh
 * milestone:  5.2 => Future Release


Comment:

 Gave this some testing today. I am noticing the following with the current
 patch:

 Before applying patch when introducing a fatal error and clicking save:
 1. Editing a plugin that is active on the primary site: the error is
 correctly flagged and prevented, but valid edits do not save.
 1. Editing a plugin that is not active on the primary site but active on a
 secondary site: the error is not flagged and gets saved (causing WSOD),
 valid edits are not saved.
 1. Editing a network active plugin: the error is not flagged and gets
 saved (causing WSOD), valid edits save correctly.
 1. Editing a theme that is active on the primary site: the error is
 correctly flagged and prevented, valid edits fail.
 1. Editing a theme that is not active on the primary site but active on a
 secondary site: the error is not flagged and gets saved (causing WSOD),
 valid edits save correctly.
 1. Editing a network activated theme active on the primary site: the error
 is correctly flagged, valid edits are not saved.
 1. Editing a network activated theme not active on the primary site but
 active on a secondary site: the error is not flagged and gets saved
 (causing WSOD), valid edits are saved.

 After applying patch when introducing a fatal error and clicking save:
 1. Editing a plugin that is active on the primary site: the error is
 correctly flagged, valid edits save correctly.
 1. Editing a plugin that is not active on the primary site but active on a
 secondary site: the error is not flagged and gets saved (causing WSOD),
 valid edits save correctly.
 1. Editing a network active plugin: the error is not flagged and gets
 saved (causing WSOD), valid edits save correctly.
 1. Editing a theme that is active on the primary site: the error is
 correctly flagged, valid edits save correctly.
 1. Editing a theme that is not active on the primary site but active on a
 secondary site: the error is not flagged and gets saved (causing WSOD),
 valid edits save correctly.
 1. Editing a network activated theme active on the primary site: the error
 is correctly flagged and prevented, valid edits save correctly.
 1. Editing a network activated theme not active on the primary site but
 active on a secondary site: the error is not flagged and gets saved
 (causing WSOD), valid edits save correctly.

 [attachment:"45755.diff"] will allow valid edits to save correctly in
 scenarios 1, 2, 3, 4 & 6, but it does not address fatal errors not being
 caught correctly in scenarios 2, 3, 5 & 7. While these are not new bugs,
 it would introduce the scenario of inadvertently saving a fatal error in
 certain scenarios. In these scenarios, it will not be immediately apparent
 that a fatal error has been introduced. Someone will most likely not visit
 a secondary site to test the edit if the admin gives them a success
 notice.

 Because of this, I think we should hold off on committing
 [attachment:"45755.diff"] until we can come up with a better fix that also
 accounts for the other scenarios.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45755#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform