[wp-trac] [WordPress Trac] #44845: _get_list_table: Support for privacy requests tables
WordPress Trac
noreply at wordpress.org
Fri Sep 21 16:11:26 UTC 2018
#44845: _get_list_table: Support for privacy requests tables
----------------------------+----------------------
Reporter: birgire | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 5.0
Component: Administration | Version: 4.9.6
Severity: normal | Resolution:
Keywords: has-patch | Focuses: privacy
----------------------------+----------------------
Changes (by desrosj):
* milestone: 4.9.9 => 5.0
Comment:
I like this idea, and the patch looks good. But, unfortunately, this is
blocked by two issues.
First, `_get_list_table()` will try to include `wp-admin/includes/class-
wp-' . $required . '-list-table.php`, which does not exist yet (see
#43895).
Second, there is a problem with the privacy request class table names that
will need to be resolved. The class names do not follow the correct
pattern. `WP_Privacy_Data_Export_Requests_Table`, for example should be
`WP_Privacy_Data_Export_Requests_List_Table`.
When a class is in its own file, the name should be `class-
actualclassname.php`. In the current state, the file for
`WP_Privacy_Data_Export_Requests_Table` would be `class-wp-privacy-data-
export-requests-table.php`, which does not match the pattern
`_get_list_table()` expects. Changing the class name is a backward
compatibility issue, so it needs to be handled carefully.
Going to move this to 5.0 for visibility and because this is at a minimum
blocked by #43895. Ideally, both of these tickets should land in 5.0.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44845#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list