[wp-trac] [WordPress Trac] #44968: Header Text color option doing two jobs, so both suffer
WordPress Trac
noreply at wordpress.org
Wed Sep 19 20:39:00 UTC 2018
#44968: Header Text color option doing two jobs, so both suffer
--------------------------------+-----------------------------
Reporter: joyously | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Options, Meta APIs | Version:
Severity: normal | Keywords:
Focuses: |
--------------------------------+-----------------------------
There are two issues, both of which have been addressed before. #23761,
#22498
The Header Text color option and the Display Site Title and Tagline option
use the same storage space (theme_mod), so there is no way to hide the
title and use the color for other header text, and when the title is
unhidden the color is (sort of) the default.
Steps to reproduce:
1. In Customizer, note the header text color for comparison later.
2. Hide the site title.
3. Save and exit the Customizer.
4. Open Customizer and unhide the site title.
5. Look at the header text color and compare to value from step 1.
What I expect:
1. The header text color could be used for other header text besides the
site title. Hiding the title should not hide the color selection.
2. The color set before the title was hidden should be restored when the
title is unhidden.
What actually happens:
1. The color option is used to indicate the visibility of the site title,
so the color is set to 'blank'.
2. Other text in the header cannot be styled with the header text color if
the site title is hidden.
3. When the site title is unhidden, the header text color option shows a
color for the swatch that is the default color, but the text input box is
empty and the color indicator shows black (as if it were 0).
Or just set the color of the header text, hide it, unhide it, and the
color you chose is gone.
I think it should be two separate options for color and hiding. I don't
know how that would affect backward compatibility, but it is the best
solution.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44968>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list