[wp-trac] [WordPress Trac] #44458: Catch WSODs and provide a means for recovery for end users

[WordPress Trac]

#44458: Catch WSODs and provide a means for recovery for end users
-------------------------------------------------+-------------------------
 Reporter:  schlessera                           |       Owner:  (none)
     Type:  task (blessed)                       |      Status:  new
 Priority:  normal                               |   Milestone:  5.0
Component:  Bootstrap/Load                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-unit-tests needs-    |     Focuses:  multisite
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by bradleyt):

 This looks like a really positive change. A few comments regarding
 44458.7.diff.

  - In `plugin.php` "shutdown-handler" is listed without the ".php", which
 is inconsistent with the other drop-in files
  - It feels like a shame that `is_protected_endpoint` is not filterable,
 to allow plugin authors to specify their own critical routes. (For
 example, an SEO plugin may wish to ensure `robots.txt` is correctly
 returned even if the site enters safe-mode)
  - In `wp_shutdown_handler_wrapper` you check if the options API has been
 loaded before trying to load `php-error.php` which feels like a mistake to
 me (why would you not want a custom error page, even if the issue cannot
 be recorded)
  - You suggest that custom `php-error.php` pages should `die()` so that
 the default `wp_die()` is not run. However, this means that sites with a
 custom `php-error.php` won't get the `is_protected_endpoint` redirect loop
 which feels a shame.
  - You default to HTTPS if `is_ssl` has not been loaded - This feels like
 a mistake as if the server does not have HTTPs setup they will be
 redirected to a browser error page, with no indication of what went wrong.
 As this feature is targeted at less advanced users, it feels more sensible
 to not do the redirect at all if is_ssl is not available.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44458#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform