[wp-trac] [WordPress Trac] #44662: Text length of the Incremental search of link in tinymce should be localizable
WordPress Trac
noreply at wordpress.org
Fri Sep 14 06:49:51 UTC 2018
#44662: Text length of the Incremental search of link in tinymce should be
localizable
-------------------------------------+---------------------
Reporter: Toro_Unit | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 5.0
Component: I18N | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-refresh | Focuses:
-------------------------------------+---------------------
Changes (by ocean90):
* keywords: has-patch => has-patch needs-refresh
* milestone: Awaiting Review => 5.0
Comment:
Thanks for the patch! A few suggestions:
* Let's try to reduce the context to 5-6 words
* Cast the value to an integer (`(int) _x( … )`)
* Provide a fallback if `(int) _x( … )` returns 0
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44662#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list