[wp-trac] [WordPress Trac] #41802: add wp_attachment_is_audio() and wp_attachment_is_video()

[WordPress Trac]

#41802: add wp_attachment_is_audio() and wp_attachment_is_video()
-------------------------+-------------------------
 Reporter:  pbiron       |       Owner:  (none)
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:
Component:  Media        |     Version:  4.9
 Severity:  normal       |  Resolution:  maybelater
 Keywords:  has-patch    |     Focuses:
-------------------------+-------------------------
Changes (by joemcgill):

 * status:  new => closed
 * resolution:   => maybelater
 * milestone:  Awaiting Review =>


Comment:

 After some discussion here, as well as the previous discussion in #25275
 and in [https://make.wordpress.org/chat/ Slack], the general consensus
 seems to be that there isn't currently a compelling reason to add these
 functions at this time. The desire to create consistency across the
 codebase with `wp_attachment_is_image()` is reasonable, but the burden
 required to maintain this consistency by adding new functions for each
 supported attachment type over time, along with the very likely potential
 of these wrapping functions diverging over time, is more persuasive at
 this time. However, if our thinking shifts in the future,
 [attachment:"41802.diff"] is a model for how we would want to execute
 this.

 Closing for now as `maybelater`.

 Any related discussion about deprecating `wp_attachment_is_image()` should
 happen in a separate ticket.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41802#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform