[wp-trac] [WordPress Trac] #44081: Privacy email request failures do not get reported if there are also successful ones

[WordPress Trac]

#44081: Privacy email request failures do not get reported if there are also
successful ones
-------------------------------------------------+-------------------------
 Reporter:  desrosj                              |       Owner:  javorszky
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.9.9
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots ui-        |     Focuses:
  feedback                                       |  administration
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  has-patch has-screenshots => has-patch has-screenshots ui-
     feedback


Comment:

 For context, it seems a few of the points @birgire pointed out stem from
 the changes in [43568], which ensures `wp_send_user_request()` returns a
 `WP_Error` instead of the result of the `wp_mail()` call.

 I took a look at other screens in core with `WP_List_Tables` to see how
 they handle instances where the user does not select items to perform an
 action on. Posts, taxonomies, users, and comments all refresh the page and
 do not show a notice. The plugins screen, however, prevents a reload and
 displays an error notice with JavaScript. I wonder if we can move the
 scenario where nothing is selected to a new ticket so that all
 `WP_List_Table` pages can benefit.

 The patch itself looks good and works well for me. There are a few minor
 alignment issues that can be fixed later. @javorszky was there a reason
 why you went with two notices (green and red) instead of one warning
 notice (orange)? I am flagging for some UI feedback, but I think that will
 prevent admin notice overload.

 Also, I think that we should account for failures when attempting to
 delete requests. `wp_delete_post()` will return `WP_Error`s when deleting
 is not successful.

 @joshuawold can you weigh in with your recommendation how best to
 implement these notices?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44081#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform