[wp-trac] [WordPress Trac] #44927: Unnecessary is_null() call in get_avatar_data()

[WordPress Trac]

#44927: Unnecessary is_null() call in get_avatar_data()
-------------------------+------------------------------
 Reporter:  JPry         |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Users        |     Version:  trunk
 Severity:  minor        |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+------------------------------

Comment (by JPry):

 Replying to [comment:4 mukesh27]:
 > if {{{ $args['url'] }}} value is empty then isset is not working.

 This is about the use of `isset( $args['url'] ) $$ ! is_null( $args['url']
 )`. It doesn't check using `empty()`, and I don't think it ''should'' be
 using `empty()`. This is because of the filter that comes directly above
 this statement. Please refer to the source code inline to see for
 yourself.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44927#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform