[wp-trac] [WordPress Trac] #44081: Privacy email request failures do not get reported if there are also successful ones

[WordPress Trac]

#44081: Privacy email request failures do not get reported if there are also
successful ones
--------------------------+-----------------------------
 Reporter:  desrosj       |       Owner:  javorszky
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.9.9
Component:  Privacy       |     Version:  4.9.6
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  administration
--------------------------+-----------------------------
Changes (by javorszky):

 * keywords:  needs-patch => has-patch


Comment:

 The diff I just uploaded (44081.2) achieves the following things:

 * if the bulk action was requested with no requests chosen, it will add an
 error with the text "There were no requests to resend emails for."
 * if the resends were all successful, it will display the successful "Re-
 sent X requests" green notice.
 * if the resends all failed, it will display a _new_ "Failed to re-send X
 requests" red notice.
 * if there's a mix of successful and failed resends, it will display both
 the successful and failed resend notices.

 ## How to test:

 * apply patch
 * have at least one request under Tools -> Erase Personal Data
 * select "Resend requests" or "Delete" from the drop down menu without
 selecting any of the requests. **This should summon the "There were no
 requests to act on"** text.
 *  you might need to edit the `wp-includes/admin/user.php and set both
 $count and $failure_count to a positive integer after the foreach loop
 * Do a resend emails bulk action again (make sure you have mailcatcher /
 mailhog / mailtrap set up, or selecting your own email address)
 * that should summon both notices with the appropriate numbers.

 [[Image(https://d3vv6lp55qjaqc.cloudfront.net/items/2S0d1t1u1U0M073T1Q0r/Screen%20Shot%202018-09-08%20at%2012.38.47.png)]]

 [[Image(https://d3vv6lp55qjaqc.cloudfront.net/items/0d142k0o2t3x2e1I4240/Screen%20Shot%202018-09-08%20at%2012.40.05.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44081#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform