[wp-trac] [WordPress Trac] #17262: wp_get_attachment_thumb_file should check new 'thumbnail' image size

WordPress Trac noreply at wordpress.org
Thu Sep 6 20:36:17 UTC 2018


#17262: wp_get_attachment_thumb_file should check new 'thumbnail' image size
-------------------------------------------------+-------------------------
 Reporter:  lonnylot                             |       Owner:
                                                 |  SergeyBiryukov
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.0
Component:  Media                                |     Version:  3.0
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug needs-unit-tests      |     Focuses:
  has-patch                                      |
-------------------------------------------------+-------------------------

Comment (by joemcgill):

 [attachment:"17262.5.diff"] looks the closest at present.

 A few thoughts:
 - The default size should probably be 'full', not 'thumbnail'
 - We still need to deprecate and replace `wp_get_attachment_thumb_file()`
 - Still needs tests.

 I don't see any of this being a priority for 5.0, but am happy to ship it
 whenever the functionality is ready.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/17262#comment:38>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list