[wp-trac] [WordPress Trac] #44500: Mark data requests failed when an expired link is clicked

WordPress Trac noreply at wordpress.org
Thu Sep 6 17:40:10 UTC 2018


#44500: Mark data requests failed when an expired link is clicked
-------------------------------------------------+-------------------------
 Reporter:  desrosj                              |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests                                          |  administration
-------------------------------------------------+-------------------------

Comment (by desrosj):

 Made adjustments based on your feedback, @garrett-eclipse.

 Not opposed to a discussion about moving the status check out of the
 function, but there could be some backward compatibility issues there so
 we should discuss this in a separate ticket.

 I don't know that a key would ever have to be re-validated, but I can see
 the potential for other flows that may want to validate a key. I have been
 drawing a parallel to the password reset process. An admin can change
 passwords without verification (user is notified, though). A user must
 confirm the request in an email. Once that request is confirmed, the key
 is erased and the process needs to be started over.

 [attachment:"44500.3.diff"] also adds unit tests for
 `wp_validate_user_request_key ()`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44500#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list