[wp-trac] [WordPress Trac] #44891: Activate button showing after theme activated

[WordPress Trac]

#44891: Activate button showing after theme activated
-------------------------------------------------+-------------------------
 Reporter:  anilhada                             |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Themes                               |     Version:  4.9.8
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch needs-     |     Focuses:  ui,
  testing                                        |  administration
-------------------------------------------------+-------------------------

Comment (by birgire):

 [attachment:"44891.3.diff"] re-adds a missing {{{$aria_label}}} from
 [attachment:"44891.2.diff"].

 We're also using an existing translation string:

 {{{
 printf( __( '<span>Active:</span> %s' ), '{{{ data.name }}}' );

 }}}

 but I wonder if we should try to remove the HTML from it?

 Regarding the naming convention:

 I wonder if instead of {{{data.active}}} it would be more explicit to use
 {{{data.isActive} for the boolean values? But {{{data.active}}} seems to
 be currently used in core, but we also have {{{data.isHueSlider}}} and
 {{{data.data.isCreating}}}.

 We also have {{{data.installed}}} in core, then should we use
 {{{data.activated}}} instead of {{{data.active}}}?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44891#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform