[wp-trac] [WordPress Trac] #43960: Support for sorting columns in WP_Privacy_Requests_Table
WordPress Trac
noreply at wordpress.org
Tue Sep 4 20:23:37 UTC 2018
#43960: Support for sorting columns in WP_Privacy_Requests_Table
---------------------------------------------+-----------------------------
Reporter: birgire | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.9.9
Component: Privacy | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests commit | Focuses: administration
---------------------------------------------+-----------------------------
Changes (by desrosj):
* keywords: has-patch has-unit-tests => has-patch has-unit-tests commit
Comment:
Looks good @birgire! The tests now pass for me and the changes work well
in my testing. [attachment:"43960.7.diff"] has a few minor adjustments.
- Add `@param` tags for `test_columns_should_be_sortable()`.
- Add `@return` tag for `filter_posts_request()`.
- Indicate that the first three paramateres returned by the data provider
method could also be `null` in the `@return` tag.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43960#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list