[wp-trac] [WordPress Trac] #44809: Safeguard `has_errors()` check in extra Customizer validation
WordPress Trac
noreply at wordpress.org
Mon Sep 3 21:21:01 UTC 2018
#44809: Safeguard `has_errors()` check in extra Customizer validation
-----------------------------------+-----------------------
Reporter: flixos90 | Owner: flixos90
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 4.9.9
Component: Customize | Version: 4.7
Severity: normal | Resolution: fixed
Keywords: has-patch fixed-major | Focuses:
-----------------------------------+-----------------------
Changes (by SergeyBiryukov):
* status: reopened => closed
* resolution: => fixed
Comment:
In [changeset:"43619" 43619]:
{{{
#!CommitTicketReference repository="" revision="43619"
Customize: Safeguard a check on the `customize_validate_{$setting_id}`
filter value to ensure it is a `WP_Error`.
While the filter is documented to only support a `WP_Error`, it has been a
common practice to return true in a validation function if no errors have
occurred. This was already caught when the same filter was executed in
`WP_Customize_Setting`, it was however missing in
`WP_Customize_Manager::validate_setting_values()`.
Props flixos90.
Merges [43578] to the 4.9 branch.
Fixes #44809.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44809#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list