[wp-trac] [WordPress Trac] #45191: Remove the 'default' textdomain on __() translation functions introduced into script-loader.php for 5.0

WordPress Trac noreply at wordpress.org
Thu Oct 25 17:26:44 UTC 2018


#45191: Remove the 'default' textdomain on __() translation functions introduced
into script-loader.php for 5.0
------------------------------+-----------------------------
 Reporter:  garrett-eclipse   |      Owner:  (none)
     Type:  defect (bug)      |     Status:  new
 Priority:  normal            |  Milestone:  Awaiting Review
Component:  I18N              |    Version:  5.0
 Severity:  normal            |   Keywords:
  Focuses:  coding-standards  |
------------------------------+-----------------------------
 Found in the 5.0 branch in the `/wp-includes/script-loader.php` is the use
 of 'default' as the textdomain for the __() translation functions;
 https://core.trac.wordpress.org/browser/branches/5.0/src/wp-includes
 /script-loader.php#L405-414

 {{{#!php
 <?php
                                                         'future' => __(
 '%s from now', 'default' ),
                                                         /* translators:
 %s: duration */
                                                         'past'   => __(
 '%s ago', 'default' ),
                                                 ),
                                         ),
                                         'formats'  => array(
                                                 'time'                =>
 get_option( 'time_format', __( 'g:i a', 'default' ) ),
                                                 'date'                =>
 get_option( 'date_format', __( 'F j, Y', 'default' ) ),
                                                 'datetime'            =>
 __( 'F j, Y g:i a', 'default' ),
                                                 'datetimeAbbreviated' =>
 __( 'M j, Y g:i a', 'default' ),
 }}}

 These should be removed as unnecessary.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45191>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list