[wp-trac] [WordPress Trac] #44416: `compact()` will throw notice for undefined variables in PHP 7.3

[WordPress Trac]

#44416: `compact()` will throw notice for undefined variables in PHP 7.3
-------------------------------------------------+-------------------------
 Reporter:  desrosj                              |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.0
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  needs-testing php73 fixed-5.0        |     Focuses:
  needs-patch                                    |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  has-patch needs-testing php73 fixed-5.0 => needs-testing php73
     fixed-5.0 needs-patch


Comment:

 Seems like I missed a few. The error caused in # was terminating the build
 after the first `phpunit` command was run. This caused multisite and AJAX
 tests to not be run. While working on fixing #, two more instances of
 showed up.

 In WP_Site_Query, `$groupby`, and `$limits` can also be undefined when
 `compact()` is called.

 To see the [https://travis-ci.org/WordPress/wordpress-
 develop/jobs/445930152 new warnings, you can check out this test build].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44416#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform