[wp-trac] [WordPress Trac] #35667: Maximum execution time error in WP_Text_Diff_Renderer_Table

[WordPress Trac]

#35667: Maximum execution time error in WP_Text_Diff_Renderer_Table
--------------------------+-----------------------
 Reporter:  ocean90       |       Owner:  ocean90
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  5.0
Component:  Revisions     |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------
Changes (by pento):

 * keywords:  needs-testing has-patch => has-patch


Comment:

 @trepmal was kind enough to send me the test data she's been working with,
 that was super helpful! ([attachment:"lorem1.txt"] and
 [attachment:"lorem2.txt"], for anyone interested.)

 I did some more cachegrind analysis based on these, but all the further
 wins I found had drastically reduce benefit: maybe a total of 30ms
 improvement from the ~260ms [attachment:"35667.5.diff"] runs in on my
 computer.

 As far as testing goes, I'm happy to go with manual testing for now.
 Setting up the infrastructure for performance regression testing is
 outside the scope of this issue. 😉

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/35667#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform