[wp-trac] [WordPress Trac] #45131: Paths are incorrect in multisite.xml

WordPress Trac noreply at wordpress.org
Sat Oct 20 04:18:55 UTC 2018


#45131: Paths are incorrect in multisite.xml
------------------------------+------------------------
 Reporter:  danielbachhuber   |       Owner:  (none)
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  5.0
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  dev-feedback      |     Focuses:  multisite
------------------------------+------------------------

Comment (by SergeyBiryukov):

 Replying to [ticket:45131 danielbachhuber]:
 > Maybe PHPUnit changed how it calculate paths?

 It did:
 https://github.com/sebastianbergmann/phpunit/commit/9740a586a143be686aeab316168dfc02c5fb4a9c
 > [BC BREAK]
 >
 > All relative paths in a configuration file are now resolved relative to
 that configuration file. When upgrading, you may need to update relative
 paths for the following configurations:
 >
 > * `testSuiteLoaderFile`
 > * `printerFile`
 > * `testsuites/file`
 > * `testsuites/exclude`

 Basically, PHPUnit 3.6.x expects a path relative to the checkout root,
 PHPUnit 4.x.x and later versions expect a path relative to the
 configuration file.

 So [25294] was not wrong, it was just specific to PHPUnit 3.6.x. Before
 [43768], all excludes were only relevant for PHP 5.2.x / PHPUnit 3.6.x,
 and later versions just ignored them, so the path didn't matter.

 For `rest-autosaves-controller.php`, I'd suggest including both paths,
 that should work for all PHPUnit versions.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45131#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list