[wp-trac] [WordPress Trac] #45038: Twenty Ten: Update theme to add Gutenberg styles and support
WordPress Trac
noreply at wordpress.org
Fri Oct 19 21:51:41 UTC 2018
#45038: Twenty Ten: Update theme to add Gutenberg styles and support
----------------------------+----------------------------
Reporter: laurelfulford | Owner: laurelfulford
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 5.0
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: needs-testing | Focuses:
----------------------------+----------------------------
Changes (by crunnells):
* keywords: needs-testing has-patch has-screenshots => needs-testing
Comment:
Found a few image margin issues here:
* Image margins need some tweaks (sorry!); bottom margins on images should
be 24px (to match paragraph margins) instead of 20px (applied to `figure`
tags)
* Aligned images inherit margins from core Gutenberg, but they don’t match
theme alignments for `.alignleft` and `.alignright` (eg: `1em` vs `24px`)
* Images with captions are missing padding on the left and right so the
background color frames the image, but this _may_ be tricky to duplicate
because the block doesn’t have any styles that are applied to the parent
block when a caption is present.
* Widget blocks that are center aligned lose their left margin so the list
marker sits outside the content area.
* Gallery block captions push outside of the image boundary (left and
right padding), so a black gradient is visible.
* Audio and video block players doesn't fill the width of the container
block
Looks good otherwise!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/45038#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list