[wp-trac] [WordPress Trac] #43316: REST API: Support autosaves
WordPress Trac
noreply at wordpress.org
Fri Oct 19 12:39:21 UTC 2018
#43316: REST API: Support autosaves
---------------------------------------------+-----------------------
Reporter: kraftbj | Owner: rmccue
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.0
Component: REST API | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests commit | Focuses: rest-api
---------------------------------------------+-----------------------
Comment (by danielbachhuber):
In `43316.22.diff`, I've [https://github.com/danielbachhuber/wordpress-
develop/pull/2 made the following changes]:
* Removed instances of `'gutenberg'` textdomain.
* Used `$this->get_fields_for_response()` to define the fields in
response. See #43874.
* Assigned extra object fields with
`$this->add_additional_fields_to_object()`.
* Ported over updated tests from Gutenberg.
* Restored use of `DOING_AUTOSAVE` constant and remove the
`wp_doing_autosave` filter. The test suite issue is addressed by running
`rest-autosaves-controller.php` in a late test suite.
On the last point, we can always improve upon the test suite
implementation later. I think keeping `DOING_AUTOSAVE` is a priority
though.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43316#comment:121>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list