[wp-trac] [WordPress Trac] #45109: Introduce editor block related functions
WordPress Trac
noreply at wordpress.org
Fri Oct 19 10:02:04 UTC 2018
#45109: Introduce editor block related functions
----------------------------+-----------------------
Reporter: desrosj | Owner: pento
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 5.0
Component: General | Version:
Severity: normal | Resolution:
Keywords: fixed-5.0 | Focuses:
----------------------------+-----------------------
Comment (by swissspidy):
@pento Please note that you forgot to remove the `gutenberg` text domain
for all the strings in `wp-includes/blocks`. I fixed those and the package
names in [attachment:"45109.diff"].
Also, not really happy with the `gutenberg_` function prefixes there.
Especially since a function like `gutenberg_draft_or_post_title()` can be
used in lots of other places like `Walker_PageDropdown::start_el()`,
`wp_prepare_attachment_for_js()`, `WP_Widget_Recent_Posts::widget()` or
`wp_ajax_find_posts()`, perhaps even more.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/45109#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list