[wp-trac] [WordPress Trac] #45125: Add theme support for responsive embeds

WordPress Trac noreply at wordpress.org
Fri Oct 19 02:08:55 UTC 2018


#45125: Add theme support for responsive embeds
-------------------------------------------------+-------------------------
 Reporter:  desrosj                              |       Owner:  (none)
     Type:  feature request                      |      Status:  new
 Priority:  normal                               |   Milestone:  5.0
Component:  Themes                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:  rest-api
  refresh                                        |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  needs-patch => has-patch has-unit-tests needs-refresh
 * focuses:  docs => rest-api


Comment:

 [attachment:"45125.diff"] contains all responsive embed related code in
 Gutenberg, except:

 - The admin body classes. This class is added along with several others
 but is dependant on `is_gutenberg_page()`, which will be one of the last
 things to be committed.
 - The `block-library` package needs to have its version bumped to `2.1.2`.
 I am seeing the following error when running `npm install` locally,
 currently:

 `Could not install from "node_modules/@wordpress/autop" as it does not
 contain a package.json file.`

 Also of note, I included the code modifying the themes REST API endpoint I
 originally posted on #45016. Going to note that there next.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45125#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list