[wp-trac] [WordPress Trac] #45045: Twenty Seventeen: Update theme to add Gutenberg styles and support
WordPress Trac
noreply at wordpress.org
Thu Oct 18 20:04:39 UTC 2018
#45045: Twenty Seventeen: Update theme to add Gutenberg styles and support
-------------------------------------------------+-------------------------
Reporter: laurelfulford | Owner:
| laurelfulford
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 5.0
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing has- | Focuses:
screenshots |
-------------------------------------------------+-------------------------
Comment (by crunnells):
I took a look, and there's a very minor issue with image margins (see
attached screenshots above). Gutenberg includes it's own margins for
`.alignleft` and `.alignright`, but they don't match the default image
margins (which should be `1.5em` instead of `1em`). Also, the bottom
margin for images is `1.5em` (inherited from the `<p>` wrapping the
image), but Gutenberg images are wrapped in a `<div>` then a `<figure>`
tag, neither of which have a `bottom-margin` by default. Some CSS:
{{{#!css
.wp-block-image .alignright {
margin-left: 1.5em;
}
.wp-block-image .alignleft {
margin-right: 1.5em;
}
.wp-block-image {
margin-bottom: 1.5em;
}
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/45045#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list