[wp-trac] [WordPress Trac] #45065: Include Gutenberg packages in WordPress core.

WordPress Trac noreply at wordpress.org
Thu Oct 18 10:44:31 UTC 2018


#45065: Include Gutenberg packages in WordPress core.
-------------------------+-------------------------
 Reporter:  omarreiss    |       Owner:  omarreiss
     Type:  enhancement  |      Status:  reopened
 Priority:  normal       |   Milestone:  5.0
Component:  General      |     Version:
 Severity:  normal       |  Resolution:
 Keywords:               |     Focuses:  javascript
-------------------------+-------------------------
Changes (by azaozz):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 [43738] introduces a possible regression. It changes the order of loading
 of tinymce.js in `class-wp-editor.php` (not related to script-loader or
 Gutenberg).

 Before the changes `do_action( 'before_wp_tiny_mce', self::$mce_settings
 );` was firing before tinymce.js was loaded. Now it fires after.

 Similarly tinymce.js was loaded after `tinyMCEPreInit` was defined, now it
 loads before. Both happen as tinymce.js is now always enqueued through
 script-loader, regardless of where it is used.

 Both of these don't affect loading of TinyMCE in core, but may affect
 plugins. Since we are trying to be very careful not to break anything in
 the 5.0 branch, thinking that change should be reverted.

 If we need to abstract some parts of `class-wp-editor.php`, lets do it,
 but thinking we shouldn't change any of the functionality there, at least
 not in 5.0 :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45065#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list