[wp-trac] [WordPress Trac] #45045: Twenty Seventeen: Update theme to add Gutenberg styles and support
WordPress Trac
noreply at wordpress.org
Wed Oct 17 03:03:22 UTC 2018
#45045: Twenty Seventeen: Update theme to add Gutenberg styles and support
-------------------------------------------------+-------------------------
Reporter: laurelfulford | Owner:
| laurelfulford
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 5.0
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing has- | Focuses:
screenshots |
-------------------------------------------------+-------------------------
Comment (by davidakennedy):
Replying to [comment:22 celloexpressions]:
> This is something that should probably be treated as more of a blocker
for 5.0 than something that needs to be compromised to hit the current
deadline (especially considering that
[https://wordpress.org/about/philosophy/ deadlines are not arbitrary]).
The bundled themes set the example for the rest of the community and
represent best practices. If they add Gutenberg support by duplicating
existing styles with different selectors, and using unwieldy selectors,
other themes will be forced to do the same. This creates a bad developer
experience and potentially compounds it by forcing another round of
reworking in the future if the plan is to revise this API in a future
release.
>
> Completely removing all existing editor styles for all themes is a major
regression that will impact the vast majority of users. And unless the API
to improve editor styles for Gutenberg is simplified, it is unlikely that
many themes will be updated. For tens (hundreds?) of millions of sites, it
is not practical to update to a new theme with Gutenberg support (or make
an immediate theme change in general). Forcing the technical debt for
backwards compatibility into themes instead of into core breaks backwards
compatibility and degrades the ability for the new editor to accurately
reflect the front end for most users.
Thanks for the continued thoughts and feedback, @celloexpressions! I don't
disagree with you, as you raise some great points.
That said, we're racing toward an MVP of Gutenberg support in default
themes. So we need to work with what we have in terms of APIs, etc. If you
have any suggestions as to how to alter the approach in the current patch
to reduce repeated code, just add a comment. There's always a better way.
We’re supporting two experiences (Gutenberg and pre-Gutenberg) in existing
themes that add Gutenberg support. No way to avoid that. So we'll have
some duplication, it won’t be perfect. But we can try to make as perfect
as can be within all the constraints.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/45045#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list