[wp-trac] [WordPress Trac] #45039: Twenty Eleven: Update theme to add Gutenberg styles and support
WordPress Trac
noreply at wordpress.org
Tue Oct 16 04:54:16 UTC 2018
#45039: Twenty Eleven: Update theme to add Gutenberg styles and support
-------------------------------------+----------------------------
Reporter: laurelfulford | Owner: laurelfulford
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 5.0
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses:
-------------------------------------+----------------------------
Changes (by laurelfulford):
* keywords: needs-patch => has-patch needs-testing
Comment:
I'll keep an eye on #45045 and incorporate anything decided there to the
other themes, but since Beta 1 is coming up fast (October 19th), I figured
it would be good to get the basic patches posted for the other themes.
[attachment:"45039.patch"] helps make sure the Gutenberg blocks match
Twenty Eleven's styles on the front-end, and adds styles for the editor.
Twenty Eleven has a couple odd challenges I haven't seen in the other
themes yet that may need to be revisited:
* It uses an older method of enqueuing styles; for the Gutenberg styles
I've followed what I've done for the other themes, but it might make more
sense to match what's already there.
* It's not possible to apply the same image caption styles to the image
block; it would require a caption class around the whole block to target
correctly, which isn't there.
* For the button blocks, I followed the button styles from the comment
form, but the offset text might look better centred when used as blocks.
I'm also attaching some screenshots of the editor before and after, since
it's the most dramatic change, but if there's anything else specific
anyone would like to see here, let me know!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/45039#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list