[wp-trac] [WordPress Trac] #45041: Twenty Thirteen: Update theme to add Gutenberg styles and support
WordPress Trac
noreply at wordpress.org
Mon Oct 15 23:58:46 UTC 2018
#45041: Twenty Thirteen: Update theme to add Gutenberg styles and support
-------------------------------------+----------------------------
Reporter: laurelfulford | Owner: laurelfulford
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 5.0
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses:
-------------------------------------+----------------------------
Comment (by laurelfulford):
> Twenty Thirteen features dynamic editor styles based on the current post
type, to reflect the front end display for each post type. We should
ensure that this functionality still works with Gutenberg and this theme
update.
Right! It looks like Gutenberg doesn't add the same classes body classes
to the editor area as the Classic editor does, so classes like `.post-
format-aside` aren't there to be used to style these posts differently.
I've created an issue here:
https://github.com/WordPress/gutenberg/issues/10640.
> Also, similar to Twenty Fourteen, there is custom styling for audio and
video players. Based on the screenshots, it appears that this is currently
broken.
Like Twenty Fourteen, it looks like Media Element.js isn't used in the
Audio and Video blocks (I found a related ticket here:
https://github.com/WordPress/gutenberg/issues/5240).
It is still used on existing audio players when they're in the Classic
blocks, but for some reason, not videos. I'll have to dig into this a bit
more to figure out what's happening.
> How does wide alignment work when the sidebar is used?
I haven't added support for wide alignment quite yet -- I'm hoping to get
MVP patches for all the themes ready before diving into that. I imagine it
will take some experimenting to figure out what makes the most sense, and
I'm open to suggestions!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/45041#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list