[wp-trac] [WordPress Trac] #45045: Twenty Seventeen: Update theme to add Gutenberg styles and support

[WordPress Trac]

#45045: Twenty Seventeen: Update theme to add Gutenberg styles and support
-------------------------------------------------+-------------------------
 Reporter:  laurelfulford                        |       Owner:
                                                 |  laurelfulford
     Type:  task (blessed)                       |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.0
Component:  Bundled Theme                        |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  screenshots                                    |
-------------------------------------------------+-------------------------

Comment (by celloexpressions):

 Replying to [comment:16 laurelfulford]:
 >  > Please upload at least the most general screenshots directly to trac
 for posterity, as any external links tend to become invalid over time.
 >
 > Oh, good point! I’ll move the images and update the links above.

 Thanks, this makes it much easier to quickly visualize the changes!

 > > editor-blocks.css in 45045.patch​ is deeply concerning. Gutenberg
 should be able to find a way to use the existing editor-style.css with
 minor modifications, or even introduce API to facilitate pulling styles
 directly from style.css…
 >
 > These are good points, but given the timeline of 5.0, will probably fall
 to later versions to address. I think they’re also part of a wider
 discussion that extends beyond the default themes and their eye to
 backwards compatibility, to future Gutenberg theme development overall.
 There is some discussion in the GitHub repo about smoothing areas of the
 editor-stylesheet experience (like
 https://github.com/WordPress/gutenberg/issues/10067). Starting an issue
 for a broader discussion could help make sure these points don’t get lost
 as Gutenberg enters Phase 2.

 This is something that should probably be treated as more of a blocker for
 5.0 than something that needs to be compromised to hit the current
 deadline (especially considering that
 [https://wordpress.org/about/philosophy/ deadlines are not arbitrary]).
 The bundled themes set the example for the rest of the community and
 represent best practices. If they add Gutenberg support by duplicating
 existing styles with different selectors, and using unwieldy selectors,
 other themes will be forced to do the same. This creates a bad developer
 experience and potentially compounds it by forcing another round of
 reworking in the future if the plan is to revise this API in a future
 release.

 Completely removing all existing editor styles for all themes is a major
 regression that will impact the vast majority of users. And unless the API
 to improve editor styles for Gutenberg is simplified, it is unlikely that
 many themes will be updated. For tens (hundreds?) of millions of sites, it
 is not practical to update to a new theme with Gutenberg support (or make
 an immediate theme change in general). Forcing the technical debt for
 backwards compatibility into themes instead of into core breaks backwards
 compatibility and degrades the ability for the new editor to accurately
 reflect the front end for most users.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45045#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform