[wp-trac] [WordPress Trac] #44979: Parameter 1 to wp_default_styles() expected to be a reference, value given

WordPress Trac noreply at wordpress.org
Mon Oct 15 00:52:28 UTC 2018


#44979: Parameter 1 to wp_default_styles() expected to be a reference, value given
---------------------------+-----------------------------
 Reporter:  jqz            |       Owner:  SergeyBiryukov
     Type:  defect (bug)   |      Status:  accepted
 Priority:  normal         |   Milestone:  5.0.1
Component:  Script Loader  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:
---------------------------+-----------------------------
Changes (by pento):

 * version:  4.9.8 =>
 * milestone:  5.0 => 5.0.1


Comment:

 I originally milestoned this for 5.0 as a possible PHP 7.3 compatibility
 issue. As it's to do with the UOPZ extension, I'm moving this to 5.0.1 for
 further evaluation.

 I suspect the fix is going to be trickier than just removing the `&` and
 changing `WP_Scripts::init()` to call `do_action()` instead, given
 historical conversations around the behaviour of this code.

 In particular, any fix will need to be tested with PHP 5.2 and 5.3, which
 had some weird object/reference behaviour that the handful of remaining
 `do_action_ref_array()` usages seem to exist to work around.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44979#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list