[wp-trac] [WordPress Trac] #14148: wp_get_attachment_url() is not url encoding

[WordPress Trac]

#14148: wp_get_attachment_url() is not url encoding
-------------------------------------------------+-------------------------
 Reporter:  danorton                             |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Security                             |     Version:  3.0
 Severity:  major                                |  Resolution:
 Keywords:  has-patch needs-testing dev-         |     Focuses:
  feedback needs-unit-tests needs-refresh        |
-------------------------------------------------+-------------------------

Comment (by nevis2us):

 Replying to [comment:20 Mte90]:
 > Cna you share the code of your custom plugin?
 > So we can understand better how to handle it.

 Sure, I can share the relevant parts of the code:


 {{{
 add_filter("wp_get_attachment_url", "<namespace>_wp_get_attachment_url",
 90, 2);

 function <namespace>_wp_get_attachment_url($url, $post_id)      {
         return encodeURI($url);
 }
 }}}

 The code for encodeURI() can be found in comment:9 above.

 This is what a plugin dev can use if he needs this bug fixed ASAP before
 the relevant patches make it to the core. But fixing this and similar
 issues in the core or in a filter may break existing 3rd party code. I
 don't use 3rd party plugins on my sites so it works for me.

 > Cna you share also an image already existing with the issues on the
 name?

 If I got you right:

 The function wp_get_attachment_url() doesn't return a valid URL if the
 filename contains UTF-8 characters.

 **Example:**

 ||attachment filename||.../wp-
 content/uploads/2015/10/Оля-в-Инстаграме.BW_.jpg||
 ||wp_get_attachment_url() returns||.../wp-
 content/uploads/2015/10/Оля-в-Инстаграме.BW_.jpg||
 ||valid URL||.../wp-
 content/uploads/2015/10/%D0%9E%D0%BB%D1%8F-%D0%B2-%D0%98%D0%BD%D1%81%D1%82%D0%B0%D0%B3%D1%80%D0%B0%D0%BC%D0%B5.BW_.jpg||

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/14148#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform