[wp-trac] [WordPress Trac] #45045: Twenty Seventeen: Update theme to add Gutenberg styles and support

[WordPress Trac]

#45045: Twenty Seventeen: Update theme to add Gutenberg styles and support
-------------------------------------------------+-------------------------
 Reporter:  laurelfulford                        |       Owner:
                                                 |  laurelfulford
     Type:  task (blessed)                       |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.0
Component:  Bundled Theme                        |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-       |     Focuses:
  screenshots                                    |
-------------------------------------------------+-------------------------

Comment (by laurelfulford):

 > Please upload at least the most general screenshots directly to trac for
 posterity, as any external links tend to become invalid over time.

 Oh, good point! I’ll move the images and update the links above.

 > Let's also consider that any front-end changes to existing content
 should be kept to an absolute minimum to avoid unexpected changes to live
 sites when updating.

 Yes, agreed! The changes are targeting the blocks specifically, to make
 sure they match the theme’s existing styles. Right now, the only selectors
 that don’t specifically target a block class (`.wp-block-*`) are for the
 colours.

 > We need to carefully consider how theme color options interact with the
 in-content color options in Gutenberg.

 True. Based on the complexity, I think we should leave the editor colour
 support out of the MVP for Twenty Seventeen. There’s definitely a lot to
 consider to make it work in a way that makes sense with the theme’s own
 custom colours, and a lot of opportunities for clashes.

 This would be consistent with Twenty Seventeen’s current editor styles,
 which don’t change based on the colour options.

 > editor-blocks.css in 45045.patch​ is deeply concerning. Gutenberg should
 be able to find a way to use the existing editor-style.css with minor
 modifications, or even introduce API to facilitate pulling styles directly
 from style.css…

 These are good points, but given the timeline of 5.0, will probably fall
 to later versions to address. I think they’re also part of a wider
 discussion that extends beyond the default themes and their eye to
 backwards compatibility, to future Gutenberg theme development overall.
 There is some discussion in the GitHub repo about smoothing areas of the
 editor-stylesheet experience (like
 https://github.com/WordPress/gutenberg/issues/10067). Starting an issue
 for a broader discussion could help make sure these points don’t get lost
 as Gutenberg enters Phase 2.

 > For Twenty Seventeen specifically, we should also think carefully about
 how the front page content feature interacts with Gutenberg. Especially
 considering its relationship to the goals of the new editor project. That
 could be anywhere from deprecating that feature (with a migration path) to
 ensuring that something similar can be achieved directly in the editor and
 keeping the feature as shipped with the original theme.

 Another good thing to consider. For the latter, that could be part of
 implementing the “wide” alignment styles in this theme.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45045#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform