[wp-trac] [WordPress Trac] #44750: Attributes unexpectedly lost in attachment links

[WordPress Trac]

#44750: Attributes unexpectedly lost in attachment links
--------------------------------------+-----------------------
 Reporter:  TimothyBlynJacobs         |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  5.0
Component:  REST API                  |     Version:  4.9.8
 Severity:  major                     |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  rest-api
--------------------------------------+-----------------------
Changes (by danielbachhuber):

 * keywords:  has-patch has-unit-tests commit => has-patch has-unit-tests


Comment:

 @TimothyBlynJacobs When I ran `phpunit --group restapi` locally, I ended
 up with this unintended side-effect:

 {{{
 svn diff tests/qunit/fixtures/wp-api-generated.js
 Index: tests/qunit/fixtures/wp-api-generated.js
 ===================================================================
 --- tests/qunit/fixtures/wp-api-generated.js    (revision 43679)
 +++ tests/qunit/fixtures/wp-api-generated.js    (working copy)
 @@ -3943,27 +3943,22 @@
          "_links": {
              "self": [
                  {
 -                    "attributes": [],
                      "href":
 "http://example.org/index.php?rest_route=/wp/v2/media/8"
                  }
              ],
              "collection": [
                  {
 -                    "attributes": [],
                      "href":
 "http://example.org/index.php?rest_route=/wp/v2/media"
                  }
              ],
              "about": [
                  {
 -                    "attributes": [],
                      "href":
 "http://example.org/index.php?rest_route=/wp/v2/types/attachment"
                  }
              ],
              "replies": [
                  {
 -                    "attributes": {
 -                        "embeddable": true
 -                    },
 +                    "embeddable": true,
                      "href":
 "http://example.org/index.php?rest_route=%2Fwp%2Fv2%2Fcomments&post=8"
                  }
              ]
 }}}

 Do you know what the cause might be?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44750#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform