[wp-trac] [WordPress Trac] #34913: Unscheduling cron jobs fails when original arguments were not an array.

[WordPress Trac]

#34913: Unscheduling cron jobs fails when original arguments were not an array.
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Cron API                             |     Version:  3.0
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests 2nd-        |     Focuses:
  opinion                                        |
-------------------------------------------------+-------------------------
Changes (by peterwilsoncc):

 * keywords:  has-patch has-unit-tests 2nd-opinion needs-refresh => has-
     patch has-unit-tests 2nd-opinion


Comment:

 [attachment:"34913.diff"] includes:

 * refreshed against trunk
 * Added deprecation check for new function `wp_get_scheduled_event()`
 * Modified `cron` option upgrade routine to ensure `$args` are stored as
 an array
 * Bumped database version as part of upgrade routine
 * Switched tests to use a data provider

 @jrf Are you able to take a look and let me know your thoughts?

 I agree with  [comment:13:ticket:35491 your comment on ticket 35491] that
 a bug fix trumps an enhancement request but would be delighted if a
 lighter touch fix presented itself. I can't think of a lighter touch
 approach though.

 TO DO: Database version may have changed by WP 5.1.0. Any commit will need
 to update these details.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/34913#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform