[wp-trac] [WordPress Trac] #45053: Customizer throws JS errors when page contains <area> tag without href attribute

WordPress Trac noreply at wordpress.org
Sat Oct 6 15:11:59 UTC 2018


#45053: Customizer throws JS errors when page contains <area> tag  without href
attribute
--------------------------+------------------------------
 Reporter:  janthiel      |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Customize     |     Version:  4.7
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+------------------------------

Comment (by dlh):

 Quick note, @janthiel — please continue to submit your patches here, not
 on GitHub. You can generate a diff to upload with `git diff --no-prefix >
 45053.diff`. The GitHub link is just an example of where you can find the
 develop repository, but PRs on GitHub aren't monitored. Sorry to be
 confusing about that.

 At first glance, I could see implementing both the failsafe and the
 selector change as a good approach. I agree with your point about
 needlessly selecting tags in core, but because `prepareLinkPreview` is
 publicly callable, the check within the function might be nice for plugin
 and theme developers.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45053#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list