[wp-trac] [WordPress Trac] #41305: Add lazily evaluated translations
WordPress Trac
noreply at wordpress.org
Thu Oct 4 18:54:29 UTC 2018
#41305: Add lazily evaluated translations
-------------------------------------------------+-------------------------
Reporter: schlessera | Owner: jnylen0
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.0
Component: I18N | Version: 4.8
Severity: normal | Resolution:
Keywords: has-patch early dev-feedback needs- | Focuses: rest-api,
testing | performance
-------------------------------------------------+-------------------------
Comment (by mnelson4):
What @TimothyBlynJacobs is saying makes sense. I don't see any reason why
`WP_String_Proxy` doesn't just declare the property `$result` (instead it
unnecessarily uses the magic method `__get()` and sets the property
dynamically).
However, is your patch right @TimothyBlynJacobs? When I apply that patch
to master I get a fatal error because the file `class-wp-string-proxy.php`
is missing.
Also, I tried to double-check your benchmark but couldn't because of the
above exception.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/41305#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list