[wp-trac] [WordPress Trac] #45435: Port Gutenberg's `removep` Function to Php
WordPress Trac
noreply at wordpress.org
Fri Nov 30 19:31:36 UTC 2018
#45435: Port Gutenberg's `removep` Function to Php
--------------------------------------+------------------------------
Reporter: conner_bw | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Editor | Version: 4.9.8
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+------------------------------
Comment (by gaveline):
Great @conner_bw :)
Now, as it's my first patch, I don't know what is the next step for a PR.
And after looking at your implementation, your big preg pattern is a
masterpiece.\\
We may want to implement it when refactoring my poor "line by line
translation" :)\\
(I Hope your pattern will fit all the tests then)
Regards.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/45435#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list