[wp-trac] [WordPress Trac] #45037: Improve the WordPress Post editing experience
WordPress Trac
noreply at wordpress.org
Sun Nov 25 09:23:19 UTC 2018
#45037: Improve the WordPress Post editing experience
-------------------------------------------------+-------------------------
Reporter: jorbin | Owner: pento
Type: task (blessed) | Status: assigned
Priority: highest omg bbq | Milestone: 5.0
Component: Editor | Version:
Severity: normal | Resolution:
Keywords: early needs-unit-tests has-patch | Focuses:
needs-testing |
-------------------------------------------------+-------------------------
Changes (by Frank Klein):
* keywords: early needs-unit-tests has-patch needs-testing fixed-5.0 =>
early needs-unit-tests has-patch needs-testing
Comment:
Reopening this, because we cannot add a `is_block_editor()` method that is
both a setter, and a getter.It goes against long established WordPress
conventions, and fundamental rules of API design.
Using `set_is_block_editor()` or `get_is_block_editor()` keeps in line
with the original method name. `set_uses_block_editor()` or
`get_uses_block_editor()` might be cleaner. The reason being that
`get_is_` is a doubled prefix. `is_` in WordPress is used for helper
functions that access a particular piece of data, without offering a
setter, so it's not the best naming choice in this case.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/45037#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list