[wp-trac] [WordPress Trac] #45402: Issues in wp_default_packages_scripts()

WordPress Trac noreply at wordpress.org
Fri Nov 23 07:57:10 UTC 2018


#45402: Issues in wp_default_packages_scripts()
---------------------------+-----------------------
 Reporter:  swissspidy     |      Owner:  (none)
     Type:  defect (bug)   |     Status:  new
 Priority:  normal         |  Milestone:  5.0
Component:  Script Loader  |    Version:  5.0
 Severity:  minor          |   Keywords:  has-patch
  Focuses:                 |
---------------------------+-----------------------
 I noticed two issues in `wp_default_packages_scripts()` simply by looking
 at the warnings the IDE threw at me.

 First of all, `api-fetch` is listed twice in `$packages_versions`.
 Second, `$scripts->add( $handle, $path, $dependencies, false, $version );`
 is wrong. `$version` needs to be the **fourth** argument. So correct would
 be `$scripts->add( $handle, $path, $dependencies, $version );`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45402>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list