[wp-trac] [WordPress Trac] #45113: Integrate compatibility related functions for the new editor

WordPress Trac noreply at wordpress.org
Wed Nov 21 18:23:14 UTC 2018


#45113: Integrate compatibility related functions for the new editor
-------------------------------------+-----------------------
 Reporter:  desrosj                  |       Owner:  pento
     Type:  task (blessed)           |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.0
Component:  General                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+-----------------------

Comment (by adamsilverstein):

 The changes in [attachment:"45113.heartbeatnonce.diff"] look good, I can
 give that some testing later in my local with nonce expiration set very
 low to verify refresh is actually working.

 I agree we can likely remove the unused nonces included in the html as
 long as we are sure they aren't used. I did a little research to see
 how/if we use these nonces:

 I think we need these nonces (and keep them refreshed) for actions taken
 within the classic editor block:

 `_ajax_linking_nonce` is for ajax requests made when using the link
 selection modal which is still available.
 `_wpnonce` is used in wp.media, think we need to retain that, I'll try to
 confirm by looking for the nonce in requests

 These I think can be dropped for GB:
 `samplepermalinknonce` is used in the classic editor for slug operations,
 we probably don't need it for Gutenberg.
 `closedpostboxesnonce` is used when persisting metabox open/closed states
 - we probably don't need for GB
 I couldn't find any use of `getpermalinknonce`

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45113#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list