[wp-trac] [WordPress Trac] #45380: Twenty Sixteen: Theme's built-in 'wide' image styles don't work with image blocks
WordPress Trac
noreply at wordpress.org
Tue Nov 20 19:27:04 UTC 2018
#45380: Twenty Sixteen: Theme's built-in 'wide' image styles don't work with image
blocks
----------------------------------------------+----------------------------
Reporter: laurelfulford | Owner: laurelfulford
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 5.0
Component: Bundled Theme | Version: 5.0
Severity: normal | Resolution:
Keywords: has-screenshots has-patch commit | Focuses:
----------------------------------------------+----------------------------
Changes (by davidakennedy):
* keywords: has-screenshots has-patch needs-testing => has-screenshots
has-patch commit
Comment:
Hey @laurelfulford – I gave this a spin following the above steps, and
didn't come up against any issues. It's good to go from me, and will make
it as such.
> It's important to note that this wide image style is not previewed in
the editor -- adding checks for the image width there seems like it could
turn into a bit of a mess, and beyond what a theme should be doing. Does
this seem like enough of an issue not to add this behaviour? I’m leaning
towards no, because the wide images also don’t preview in the classic
editor, and this will make the image blocks behave more consistently with
existing content in Twenty Sixteen. I’m interested to know what other
people think, though!
I agree with your thinking here. I'm not sure there would be an easy way
to make that work without creating a mess of code. That's a case where
this is an older theme, and that's okay it doesn't preview exactly the
right way. If Twenty Sixteen launched today, it wouldn't have that
functionality, but instead leave it up to the user to control it with wide
images.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/45380#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list