[wp-trac] [WordPress Trac] #45066: Replace wp-a11y.js with @wordpress/a11y package
WordPress Trac
noreply at wordpress.org
Mon Nov 19 19:18:00 UTC 2018
#45066: Replace wp-a11y.js with @wordpress/a11y package
----------------------------------+----------------------------------------
Reporter: omarreiss | Owner: omarreiss
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.0.1
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs- | Focuses: accessibility, javascript
testing |
----------------------------------+----------------------------------------
Comment (by desrosj):
Talked this through with @herregroen and wanted to put this here for
visibility. Locally, the tests in the most recent patch fail for me. But
it is a `.min` vs no `.min` issue. My site was provisioned in VVV using
`trunk`, which has the following conditional:
{{{
if ( defined( 'WP_RUN_CORE_TESTS' ) && WP_RUN_CORE_TESTS ) {
define( 'ABSPATH', dirname( __FILE__ ) . '/build/' );
} else {
define( 'ABSPATH', dirname( __FILE__ ) . '/src/' );
}
}}}
`WP_RUN_CORE_TESTS` is defined in `phpunit.xml.dist` as `1` and would
cause the tests to return the minified versions.
When this gets ported over to `trunk`, the tests may need to change to
look for the minified versions.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/45066#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list