[wp-trac] [WordPress Trac] #45018: Non-string needle parameters throw warning in PHP 7.3

[WordPress Trac]

#45018: Non-string needle parameters throw warning in PHP 7.3
-------------------------------------------+---------------------
 Reporter:  desrosj                        |       Owner:  (none)
     Type:  defect (bug)                   |      Status:  new
 Priority:  normal                         |   Milestone:  5.0
Component:  General                        |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  php73 has-patch needs-testing  |     Focuses:
-------------------------------------------+---------------------

Comment (by desrosj):

 Alright, updated patch incoming. If only the test is added, it will pass
 on all versions of PHP except `7.3`. On `7.3`, it will throw the same
 warning the other test method was throwing. The additional changes in the
 patch fix the issue for both tests.

 Here are a few builds:
 - [https://travis-ci.org/desrosj/wordpress-develop/builds/455677734 Only
 the new test method introduced].
 - [https://travis-ci.org/desrosj/wordpress-develop/builds/455677990 The
 entire patch].

 I fell into a bit of a rabbit hole trying to figure out why the test was
 failing and realized it was due to funky behavior with numeric menu slugs.
 I have opened #45361 to better address that.

 This should also be the last change preventing the `7.3` job from passing.
 I removed `7.3` from the allowed failures list in the Travis configuration
 in the new patch.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45018#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform