[wp-trac] [WordPress Trac] #43826: get_post_galleries() should return gallery blocks
WordPress Trac
noreply at wordpress.org
Wed Nov 14 07:20:41 UTC 2018
#43826: get_post_galleries() should return gallery blocks
----------------------------------------------------+---------------------
Reporter: pento | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 5.0
Component: Media | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests needs-testing | Focuses:
----------------------------------------------------+---------------------
Comment (by tellyworth):
attachment:43826.3.diff improves the tests as per @birgire's suggestions,
specifically:
* `@group blocks` added to block tests
* Added `test_mixed_post_gallery_images()` to cover mixed shortcode/block
case
* Shortened the tests using single ranges (also for some older tests)
Re `$html = false`, it seems like all of the tests cover these cases
currently; it's `true` that is not covered. I'll look at adding those
next.
Has anyone tested this manually?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43826#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list