[wp-trac] [WordPress Trac] #45299: `wpdb->last_result` may not be countable

WordPress Trac noreply at wordpress.org
Tue Nov 13 01:47:24 UTC 2018


#45299: `wpdb->last_result` may not be countable
-------------------------------------------+---------------------
 Reporter:  desrosj                        |       Owner:  (none)
     Type:  defect (bug)                   |      Status:  new
 Priority:  normal                         |   Milestone:  5.0
Component:  Database                       |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  php73 has-patch needs-testing  |     Focuses:
-------------------------------------------+---------------------
Changes (by dd32):

 * keywords:  php73 needs-patch => php73 has-patch needs-testing
 * component:  Query => Database


Comment:

 A visual review of the diffs looks good, marking as `has-patch, needs-
 testing`.

 - [attachment:"45299-bug1.diff"] matches the check used next block down
 for `ARRAY_*`.
 - [attachment:"45299.diff"] `get_col()` differs from the rest of the
 `get_*()` methods which return `null` in this case, and always returns an
 array, so this also seems like a sane change.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45299#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list