[wp-trac] [WordPress Trac] #45283: Meta Boxes: Add an action for plugins to print hidden inputs in the meta box form

WordPress Trac noreply at wordpress.org
Tue Nov 6 23:38:39 UTC 2018


#45283: Meta Boxes: Add an action for plugins to print hidden inputs in the meta
box form
-------------------------------------+-----------------------
 Reporter:  pento                    |       Owner:  pento
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.0
Component:  Editor                   |     Version:  5.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:
-------------------------------------+-----------------------

Comment (by pento):

 Yeah, that's why it does the `wp_html_split()`, which reliably breaks
 everything up into an array of HTML nodes, then we can do simple checks to
 ensure we're only getting the hidden input fields.

 > Do you think this runs the risk of any execution order bugs?

 I don't think so, given that they're both run after `admin-header.php` in
 `edit-form-advanced.php`. It seems like this would give us more reliable
 output than the current method.

 I'm pondering how we should mark this practice as not recommended, though.
 Maybe `do_action_deprecated()`, though I'm not sure if we've ever marked
 an action as deprecated in a certain context, but not deprecated in
 others.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45283#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list