[wp-trac] [WordPress Trac] #44775: Twenty Seventeen: Ordered List's "start" attribute doesn't work inside Post/Page Editor
WordPress Trac
noreply at wordpress.org
Fri Nov 2 22:26:38 UTC 2018
#44775: Twenty Seventeen: Ordered List's "start" attribute doesn't work inside
Post/Page Editor
-----------------------------------------------------+---------------------
Reporter: mmaumio | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.0.1
Component: Bundled Theme | Version: 4.9.8
Severity: normal | Resolution:
Keywords: has-patch has-screenshots needs-refresh | Focuses:
-----------------------------------------------------+---------------------
Changes (by laurelfulford):
* keywords: has-patch needs-testing has-screenshots 2nd-opinion => has-
patch has-screenshots needs-refresh
* milestone: Awaiting Review => 5.0.1
Comment:
Thank you for reporting this issue, @mmaumio, and for your patch!
The bold numbered styles were originally going to be in Twenty Seventeen,
but they ended up causing some issues (like breaking the `start`
attribute) and were removed from the front end. It looks like they were
missed in the editor styles, though.
I've tested your patch, and the fix looks good! The start attribute is
actually followed now, and lists are styled to look like they do on the
front-end.
One thing I do notice is that there's still a bit of CSS left in the
editor-style.css related to the old list styles -- specifically:
{{{
ol {
counter-reset: item;
}
}}}
and
{{{
.rtl ol {
counter-reset: item;
}
}}}
Neither of these styles is actually causing an issue, but they're also no
longer needed. Are you able to refresh your patch with those styles
removed as well?
Just let me know if you have any questions at all about the above!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44775#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list