[wp-trac] [WordPress Trac] #43967: Admin emails after email confirmation don't work for GDPR requests

[WordPress Trac]

#43967: Admin emails after email confirmation don't work for GDPR requests
---------------------------------+---------------------------------
 Reporter:  garrett-eclipse      |       Owner:  iandunn
     Type:  enhancement          |      Status:  accepted
 Priority:  low                  |   Milestone:  4.9.7
Component:  Privacy              |     Version:  trunk
 Severity:  normal               |  Resolution:
 Keywords:  gdpr has-unit-tests  |     Focuses:  ui, administration
---------------------------------+---------------------------------

Comment (by desrosj):

 [attachment:43967.6.diff] has the changes noted below.

 > - Should the tests check the user_request_action_confirmed action works
 properly?

 I don't know that I have seen any tests before verifying that an action
 hook fires successfully (except the tests for the hooks API).

 > - Should the tests check that _wp_admin_notified is updated on the
 request post?

 Added tests for this.

 > - Should the tests be duplicated for erasure requests?
 > - Should the tests try and confirm a completed request?

 See #44234 for erasure request related tests.

 > - Should any tests try to trigger the user_request_action_confirmed by
 loading the login page with confirmaction?

 I couldn't find any tests for anything similar. May be worth investigating
 tests for the `wp-login.php` page separately.

 > - Should any tests be done when the request doesn’t exist or was removed
 somehow?

 Added assertions for the early returns in the function (an invalid post ID
 is provided, or an ID that is not of the `user_request` post type).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43967#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform